Are you sure this actually results in a usable and correct value?

Since the spec doesn't say what is returned and browser implementations
differ, my opinion is that we should do one of the following:
1) change the return values to void, breaking the API for those callers
that actually use the return value.
2) add a return this.getTime() at the end of all of these setters

The problem with #2 is that adds bloat to all callers who don't use the
return value.  In the case of #1, the docs didn't say what the return
value is, so they were already treading on thin ice anyway.

So, my preference would be #1.

http://gwt-code-reviews.appspot.com/1704804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to