https://gwt-code-reviews.appspot.com/1660803/diff/1/user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java
File
user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java
(right):
https://gwt-code-reviews.appspot.com/1660803/diff/1/user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java#newcode267
user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java:267:
returnState.getResolver().resolveClientValue(domainObject,
id.getProxyClass(),
On 2012/05/11 00:41:27, skybrian wrote:
On 2012/05/10 07:50:37, tbroyer wrote:
Okay, this is starting to make sense. So createReturnOperations is
building the
changes to be sent to the client. We need to update some server-side
caches here
(such as updating id) and then fetch the data from the cache later.
But this
shouldn't be necessary for values because their id never changes.
Maybe add a comment that this line modifies "id". (Which isn't even
passed in.
Weird.)
Do you know which tests exercise this code?
Basically any code that uses a ValueProxy; i.e. SimpleValueProxy.
I wonder if you'd notice any performance change within the tests though,
which don't make use of a lot of them. You could do something like:
SimpleFooRequest ctx = simpleFooRequest();
for (int i = 0; i < 100; i++) {
ctx.create(SimpleValueProxy.class);
}
ctx.fire(new Receiver<Void>() {
public void onSuccess(Void result) {
finishTest();
}
});
https://gwt-code-reviews.appspot.com/1660803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
