http://gwt-code-reviews.appspot.com/1700803/diff/7001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right):
http://gwt-code-reviews.appspot.com/1700803/diff/7001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1138 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1138: private void ensureInjectedCssFields() { On 2012/05/27 19:26:12, rdayal wrote:
<thought bubble> I wonder if this leads to code bloat (i.e. having to litter these
calls before
accessing a CSSResource field). Why don't we just have a static init
in
CSSResource classes </thought bubble>
ACK. I agree, but I can't say why this strange design decision. Perhaps one of the old timers would know. I'll ask. http://gwt-code-reviews.appspot.com/1700803/diff/7001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1571 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1571: * the getter must have a single parameter, the parameter type matches On 2012/05/27 19:26:12, rdayal wrote:
How about - "If the getter return type is assignable to Element, the getter must
have a
single parameter, and the parameter type must be assignable to
Element. Done. http://gwt-code-reviews.appspot.com/1700803/diff/7001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1576 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1576: private void validateRendererGetters(JClassType owner) throws UnableToCompleteException { On 2012/05/27 19:26:12, rdayal wrote:
Stupid question - when this method is called, isn't the owner that is
passed in
the name of the interface (i.e. MyUiBinder, which extends UiBinder)?
In that
case, how can there be any getters? Isn't it an empty interface in all
cases? The difference here is that the interface is extending UiRenderer which does allow getters. See here: https://docs.google.com/document/d/1Oo_imxskoGX5O9l9LhHDtJ0yJkHvNTNQqU3dkkekZYI/edit http://gwt-code-reviews.appspot.com/1700803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
