I mostly looked over the build process. (Since this is experimental, I suppose it can all be done later.)
http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/META-INF/MANIFEST.MF File elemental/META-INF/MANIFEST.MF (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/META-INF/MANIFEST.MF#newcode1 elemental/META-INF/MANIFEST.MF:1: Manifest-Version: 1.0 Do we need this file? http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/README File elemental/README (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/README#newcode1 elemental/README:1: Elemental is a "to the metal" raw programming API designed to keep up with fast changing Maybe wrap to 80 columns? (Also in STOP.EXPERIMENTAL.) http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/README File elemental/idl/README (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/README#newcode7 elemental/idl/README:7: 4) cp -r generated/src/elemental/* ../src/elemental/ These instructions are out of date since we're generating the code now. http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/css/generate-style.py File elemental/idl/css/generate-style.py (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/css/generate-style.py#newcode1 elemental/idl/css/generate-style.py:1: #!/usr/bin/python2.4 Google style is to leave this out. (We're not using it anyway.) http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/css/generate-style.py#newcode11 elemental/idl/css/generate-style.py:11: __author__ = 'danila...@google.com (Daniel Danilatos)' remove for open source release? http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/docs/README File elemental/idl/docs/README (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/docs/README#newcode1 elemental/idl/docs/README:1: W3C documentation from MDN taken from the Dart project's MDN scraper. This directory is empty, so I assume the README is just a placeholder to make sure it's here for generated files. Maybe say something about that? (Otherwise, remove.) http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/elemental/elemental.idl File elemental/idl/elemental/elemental.idl (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/elemental/elemental.idl#newcode3 elemental/idl/elemental/elemental.idl:3: * License TBD Fix? Also, add a pointer to a doc explaining the syntax used here. http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/elemental/elemental.idl#newcode25 elemental/idl/elemental/elemental.idl:25: // FIXME: thread datatbase to all the clients that need it and probably Which database? What does this mean? http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/elemental/elemental.idl#newcode163 elemental/idl/elemental/elemental.idl:163: // TODO(dstockwell): Define these manually. Does this TODO make sense for elemental? http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/elemental/elemental.idl#newcode216 elemental/idl/elemental/elemental.idl:216: // TODO(vsm): Define new names for these (see b/4436830). Seems to be left over from Dart? http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/elemental/elemental.idl#newcode349 elemental/idl/elemental/elemental.idl:349: /* suppressed, we don't support covariant return, just cast to the clamped interface if needed */ still true in Java? http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/scripts/all_tests.py File elemental/idl/scripts/all_tests.py (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/scripts/all_tests.py#newcode1 elemental/idl/scripts/all_tests.py:1: #!/usr/bin/python At some point we should probably make BUILD and build.xml targets to run these tests. http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/scripts/database.py File elemental/idl/scripts/database.py (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/scripts/database.py#newcode4 elemental/idl/scripts/database.py:4: # BSD-style license that can be found in the LICENSE file. I guess we need the LICENSE file here? http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/scripts/database.py#newcode26 elemental/idl/scripts/database.py:26: FremontCut syntax, which is derived from the Web IDL syntax and includes Context? A Google search doesn't find any results for "FremontCut syntax" outside the Dart code base. http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/scripts/idlparser.dart File elemental/idl/scripts/idlparser.dart (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/scripts/idlparser.dart#newcode1 elemental/idl/scripts/idlparser.dart:1: // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file Do we need this file? (And other dart files.) http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/scripts/logging.conf File elemental/idl/scripts/logging.conf (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/scripts/logging.conf#newcode1 elemental/idl/scripts/logging.conf:1: [loggers] What uses this? Is this python or dart? http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/templates/java_impl.darttemplate File elemental/idl/templates/java_impl.darttemplate (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/idl/templates/java_impl.darttemplate#newcode2 elemental/idl/templates/java_impl.darttemplate:2: package $PACKAGE; Hmm, this looks like Java. We should probably change the extension. http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/tests/elemental/AllTests.java File elemental/tests/elemental/AllTests.java (right): http://gwt-code-reviews.appspot.com/1728806/diff/1/elemental/tests/elemental/AllTests.java#newcode38 elemental/tests/elemental/AllTests.java:38: public class AllTests { Need a BUILD and build.xml target for this. http://gwt-code-reviews.appspot.com/1728806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
