http://gwt-code-reviews.appspot.com/1746803/diff/6001/user/src/com/google/gwt/validation/client/impl/ConstraintViolationImpl.java
File
user/src/com/google/gwt/validation/client/impl/ConstraintViolationImpl.java
(right):

http://gwt-code-reviews.appspot.com/1746803/diff/6001/user/src/com/google/gwt/validation/client/impl/ConstraintViolationImpl.java#newcode158
user/src/com/google/gwt/validation/client/impl/ConstraintViolationImpl.java:158:
return false;
Try formatting this as

return (message == null ? other.message == null :
message.equals(other.message) &&
  propertyPath == null ? other.propertyPath ==null  :
propertyPath.equals(other.propertyPath) &&

http://gwt-code-reviews.appspot.com/1746803/diff/6001/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
File
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
(right):

http://gwt-code-reviews.appspot.com/1746803/diff/6001/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java#newcode1582
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:1582:
|| (includedAnnotations.contains(annotation) && useField)) {
Does this rely one processing useField = false first?

At least leave a comment on this here, or perhaps includedAnnotations,
should take useField into account.

http://gwt-code-reviews.appspot.com/1746803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to