LGTM


http://gwt-code-reviews.appspot.com/1749803/diff/12001/dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java
File dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java (right):

http://gwt-code-reviews.appspot.com/1749803/diff/12001/dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java#newcode82
dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java:82:
ProgressLogger(TreeLogger logger, TreeLogger.Type logLevel, int
maxProgressUnits,
Hmm, do you have a test that you intend to use with this constructor? If
not, I'd rather have just one constructor.

http://gwt-code-reviews.appspot.com/1749803/diff/12001/dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java#newcode137
dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java:137: if
(elapsedNanos / NANOSECONDS_IN_SECOND < LOG_BLACKOUT_PERIOD) {
Nit, sorta: I'd normally write this using multiplication rather than
division. (Multiplying two constants can be done in advance.)

http://gwt-code-reviews.appspot.com/1749803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to