Partial review.  More to follow

http://gwt-code-reviews.appspot.com/1798803/diff/1/user/src/com/google/gwt/validation/client/Group.java
File user/src/com/google/gwt/validation/client/Group.java (right):

http://gwt-code-reviews.appspot.com/1798803/diff/1/user/src/com/google/gwt/validation/client/Group.java#newcode26
user/src/com/google/gwt/validation/client/Group.java:26: * Modified for
use with GWT.
Is this copied from some where ?

http://gwt-code-reviews.appspot.com/1798803/diff/1/user/src/com/google/gwt/validation/client/Group.java#newcode32
user/src/com/google/gwt/validation/client/Group.java:32: private
Class<?> group;
make all the fields final.

http://gwt-code-reviews.appspot.com/1798803/diff/1/user/src/com/google/gwt/validation/client/Group.java#newcode53
user/src/com/google/gwt/validation/client/Group.java:53: this.group =
group;
Test for null here.

http://gwt-code-reviews.appspot.com/1798803/diff/1/user/src/com/google/gwt/validation/client/GroupChain.java
File user/src/com/google/gwt/validation/client/GroupChain.java (right):

http://gwt-code-reviews.appspot.com/1798803/diff/1/user/src/com/google/gwt/validation/client/GroupChain.java#newcode34
user/src/com/google/gwt/validation/client/GroupChain.java:34: * Modified
for use with GWT.
What did you modify?  and from what.

http://gwt-code-reviews.appspot.com/1798803/diff/1/user/src/com/google/gwt/validation/client/GroupChain.java#newcode41
user/src/com/google/gwt/validation/client/GroupChain.java:41: private
List<Group> groupList = new ArrayList<Group>();
final

http://gwt-code-reviews.appspot.com/1798803/diff/1/user/src/com/google/gwt/validation/client/GroupChain.java#newcode49
user/src/com/google/gwt/validation/client/GroupChain.java:49: public
void assertDefaultGroupSequenceIsExpandable(List<Class<?>>
defaultGroupSequence)
assert has assumed meaning in java.  Call this check.

http://gwt-code-reviews.appspot.com/1798803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to