http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java File user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java (right):
http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java#newcode397 user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java:397: fieldWriter.setInitializer(resourceName); On 2012/08/06 22:01:32, rdayal wrote:
Add a comment that this statement is necessary (for the generator infrastructure) even though it has no ultimate effect.
Done. http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right): http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1939 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1939: fieldManager.convertFieldToGetter(param.getName()); On 2012/08/06 22:01:32, rdayal wrote:
Make this more explicit. Create a method like fieldManager.doNotOptimize(param.getName()).. in the method comment,
you can
explain that you don't want to optimize due to the lack of @UiField
annotations
and the dual-purpose (UIRenderer and UIBinder that the generator
serves).. Done. http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1939 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1939: fieldManager.convertFieldToGetter(param.getName()); On 2012/08/06 22:01:32, rdayal wrote:
Make this more explicit. Create a method like fieldManager.doNotOptimize(param.getName()).. in the method comment,
you can
explain that you don't want to optimize due to the lack of @UiField
annotations
and the dual-purpose (UIRenderer and UIBinder that the generator
serves).. Done. http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1952 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1952: // private init_fields() { On 2012/08/06 22:01:32, rdayal wrote:
build_fields, not init_fields
Done. http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode1953 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1953: w.write("private void build_fields() {", implClassName); On 2012/08/06 22:01:32, rdayal wrote:
Why is the param being passed in?
Done. http://gwt-code-reviews.appspot.com/1794803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
