On 2012/09/10 12:03:20, jtamplin wrote:
BTW: you should create code reviews at
http://gwt-code-reviews.appspot.com/
instead.
There is a also a TODO to support SafeHtml here. I'm not entirely
sure what
that means in this case (Doesn't TextBox already ensure the string is uninterpreted? Does changing to a ValueBoxBase mean you might be
displaying
HTML in a value?), but we should either make sure this change moves us
closer to
that or remove the TODO.
Could it have rather been about the SuggestionDisplay? Sounds hard to add (would require a breaking-change in SuggestOracle.Suggestion, or possibly a new interface, and a breaking change to SuggestBox.SuggestionDisplay). At this point, we'd probably better rebuild SuggestBox from scratch with better modularity (possibly even build it as an extender/behavior, similar to ASP.NET AJAX's AutoComplete http://www.asp.net/ajaxlibrary/act_AutoComplete.ashx) and allowing for auto-completing parts of the valuebox's value (similar to Closure Library's AutoComplete http://closure-library.googlecode.com/svn/docs/class_goog_ui_ac_AutoComplete.html) In other words, we should probably remove this TODO, or change it to a comment suggesting the above. https://codereview.appspot.com/6492092/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
