http://gwt-code-reviews.appspot.com/1828803/diff/1/samples/dynatablerf/pom.xml File samples/dynatablerf/pom.xml (right):
http://gwt-code-reviews.appspot.com/1828803/diff/1/samples/dynatablerf/pom.xml#newcode55 samples/dynatablerf/pom.xml:55: <!-- Doesn't yet work in eclipse. See maven-processor-plugin below. This dependency is no longer needed (and the comment wrong) http://gwt-code-reviews.appspot.com/1828803/diff/1/samples/dynatablerf/pom.xml#newcode110 samples/dynatablerf/pom.xml:110: <source>1.6</source> Those tabs should be spaces. http://gwt-code-reviews.appspot.com/1828803/diff/1/samples/dynatablerf/pom.xml#newcode128 samples/dynatablerf/pom.xml:128: <version>2.3.0-1</version> Latest version is 2.5.0-rc1, which depends on GWT 2.5.0-rc1 (so the plugin dependencies below are no longer needed; FYI, it also removes the unneeded dependency on gwt-servlet) FYI, I'll publish 2.5.0-rc2 as soon as GWT 2.5 RC2 is out, and similarly for the final release. All in all, I'd keep the plugin dependencies in (minus gwt-servlet), as it's unlikely gwt-maven-plugin 2.5.0-rc2 is released on the same week as GWT 2.5 RC2, making it impossible to bump gwtVersion in time for the GWT release (there would be a version mismatch between the project dependencies and the plugin dependencies) or making the samples unusable for a few days (in case both versions are changed, in prevision to the gwt-maven-plugin release). In the long term, I'd like the gwt-maven-plugin to be "adopted" (rewritten?) by the GWT project, but that's another story ;-) http://gwt-code-reviews.appspot.com/1828803/diff/1/samples/dynatablerf/pom.xml#newcode193 samples/dynatablerf/pom.xml:193: <!-- Mark the project for Google Plugin for Eclipse (GPE) --> Is this still needed? Isn't the GPE smart enough? (I thought it'd automatically add the nature and build command upon detecting the use of the gwt-maven-plugin and/or gwt-user dependency) http://gwt-code-reviews.appspot.com/1828803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
