http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java File user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java (right):
http://gwt-code-reviews.appspot.com/1859803/diff/2001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java#newcode216 user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java:216: protected JavaCompiler getJavaCompiler() { On 2012/10/24 20:52:30, skybrian wrote:
Not a big deal, but I usually prefer to introduce a field and
constructor arg
for configuration, to avoid starting a class hierarchy.
+1 http://gwt-code-reviews.appspot.com/1859803/diff/6001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java File user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java (right): http://gwt-code-reviews.appspot.com/1859803/diff/6001/user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java#newcode212 user/src/com/google/web/bindery/requestfactory/apt/ValidationTool.java:212: public void run(String[] args) throws IOException { Er, why this method? Couldn't the System.exit be in the main()? System.exit(new ValidationTool().exec(args) ? 0 : -1); or boolean successful = new ValidationTool().exec(args); System.exit(successful ? 0 : -1); http://gwt-code-reviews.appspot.com/1859803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
