Reviewers: mdempsky,

Description:
CSS Media types are comma separated.


Please review this at http://gwt-code-reviews.appspot.com/1861804/

Affected files:
  M user/src/com/google/gwt/resources/css/CssGenerationVisitor.java
  M user/test/com/google/gwt/resources/css/CssNodeClonerTest.java
  M user/test/com/google/gwt/resources/css/media.css


Index: user/src/com/google/gwt/resources/css/CssGenerationVisitor.java
===================================================================
--- user/src/com/google/gwt/resources/css/CssGenerationVisitor.java (revision 11357) +++ user/src/com/google/gwt/resources/css/CssGenerationVisitor.java (working copy)
@@ -186,8 +186,15 @@
   @Override
   public boolean visit(CssMediaRule x, Context ctx) {
     out.print("@media");
+    boolean isFirst = true;
     for (String m : x.getMedias()) {
-      out.print(" " + m);
+      if (isFirst) {
+        spaceOpt();
+        isFirst = false;
+      } else {
+        comma();
+      }
+      out.print(m);
     }
     spaceOpt();
     out.print("{");
Index: user/test/com/google/gwt/resources/css/CssNodeClonerTest.java
===================================================================
--- user/test/com/google/gwt/resources/css/CssNodeClonerTest.java (revision 11357) +++ user/test/com/google/gwt/resources/css/CssNodeClonerTest.java (working copy)
@@ -63,7 +63,7 @@

     CssStylesheet cloned = CssNodeCloner.clone(CssStylesheet.class, sheet);

-    assertEquals("@media print {\n}\n", cloned.toString());
+    assertEquals("@media print, standard {\n}\n", cloned.toString());
   }

   public void testCloneProperty() {
Index: user/test/com/google/gwt/resources/css/media.css
===================================================================
--- user/test/com/google/gwt/resources/css/media.css    (revision 11357)
+++ user/test/com/google/gwt/resources/css/media.css    (working copy)
@@ -14,4 +14,4 @@
  * the License.
  */

-@media print {}
+@media print, standard {}


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to