http://gwt-code-reviews.appspot.com/1873803/diff/1/user/src/com/google/gwt/dom/client/Element.java File user/src/com/google/gwt/dom/client/Element.java (right):
http://gwt-code-reviews.appspot.com/1873803/diff/1/user/src/com/google/gwt/dom/client/Element.java#newcode104 user/src/com/google/gwt/dom/client/Element.java:104: setClassName(oldClassName + " " + className); Would it break anything if we unconditionally did this even if oldClassName is the empty string ? (BTW, we now require Java 6 and have emulated isEmpty() for long, so we could also use it instead of length()>0) http://gwt-code-reviews.appspot.com/1873803/diff/1/user/src/com/google/gwt/dom/client/Element.java#newcode565 user/src/com/google/gwt/dom/client/Element.java:565: static int indexOfName(String nameList, String name) { I wonder if this wouldn't be faster: return (" " + nameList + " ").indexOf(" " + name + " "); It sure is easier to read IMO ;-) http://gwt-code-reviews.appspot.com/1873803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
