You might want to try out Git/Gerrit ;-)

http://gwt-code-reviews.appspot.com/1880803/diff/1/user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1880803/diff/1/user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java#newcode775
user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java:775: if
(input != null) {
There's com.google.gwt.util.tools.Utility.close(InputStream) already.

We might want to factor all those close() methods into one that takes a
Closeable argument so we can also use it for the
MemoryCacheImageInputStream.

http://gwt-code-reviews.appspot.com/1880803/diff/1/user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java#newcode778
user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java:778: if
(imageStream != null) {
There should be a try/catch for each stream; and we should probably
close the MemoryCacheImageInputStream before the underlying InputStream.

http://gwt-code-reviews.appspot.com/1880803/diff/1/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
File user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
(right):

http://gwt-code-reviews.appspot.com/1880803/diff/1/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java#newcode571
user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java:571:
int originalSize = contentLocationConnection.getContentLength();
How about adding:

private getContentLength(URL url) throws IOException {
  URLConnection conn = url.openConnection();
  try {
    return conn.getContentLength();
  } finally {
    Utility.close(conn.getInputStream());
  }
}

and using it as "int originalSize = getContentLength(contentLocation)"

http://gwt-code-reviews.appspot.com/1880803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to