Thomas Broyer has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
......................................................................
Patch Set 5:
For me, it would be enough to add to the "never expire" comment; somethin
like: "never expire, would loop indefinitely if the loop always waited
TIME_SLICE, and the test would timeout", and add a link to the issue in the
javadoc for the test.
(I would have done it entirely differently: call runRepeatingTasks
directly, and in the mock Duration assert that it hasn't been called more
times than the task +/-1, and when it returns, check that the returned list
is empty and the task has been called enough times; your test is fine
though, I'm possibly/probably too "low-level" here)
--
To view, visit https://gwt-review.googlesource.com/1750
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <kurka.dan...@gmail.com>
Gerrit-Reviewer: Daniel Kurka <kurka.dan...@gmail.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
