Brian Slesinsky has posted comments on this change.
Change subject: Emit a warning if (some) incompatible options are used.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Line 490: if (options.isClosureCompilerEnabled() &&
options.isCompilerMetricsEnabled() {
This is okay, but it seems like it would be clearer like this?
if (options.isClosureCompilerEnabled()) {
... log warnings based on options ...
} else {
... run reports based on options ...
}
--
To view, visit https://gwt-review.googlesource.com/1760
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e73b0107c23e54b69b9e648bff05d2135ff0b77
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
