http://gwt-code-reviews.appspot.com/1879803/diff/6004/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
File user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
(right):

http://gwt-code-reviews.appspot.com/1879803/diff/6004/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java#newcode1796
user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java:1796:
* In non-HTML implementations, the cell parent is the table cell div
element.
I'm not following this part of the comment (HTML vs non-HTML). It looks
like the rest is enough though.

http://gwt-code-reviews.appspot.com/1879803/diff/6004/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java#newcode1802
user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java:1802:
cellParent = target.getFirstChildElement();
my suggestion was to switch the starting point of all searches inside
the loop when the target element is a TD element. Basically it means
"work same as something inside the TD element was clicked". This is also
consistent with the second part of the comment above.
Setting the cell parent out of the loop will be more confusing to the
readers who tries to follow the code.
(if you disagree, feel free to get other reviewer's opinions here)

http://gwt-code-reviews.appspot.com/1879803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to