Brian Slesinsky has posted comments on this change.
Change subject: Remove unnecessary wrapping of IOException in
DiskCacheToken. Instead, catch the exception at the artifact level and log
it with some context.
......................................................................
Patch Set 1:
(2 comments)
....................................................
File dev/core/src/com/google/gwt/core/ext/linker/EmittedArtifact.java
Line 223: throws IOException, UnableToCompleteException {
Good point; reverted. I changed it so we log an error and throw
UnableToComplete in the usual way, since that seems to makes the most sense
for artifacts.
....................................................
File dev/core/src/com/google/gwt/dev/util/DiskCacheToken.java
Line 72
I deleted readString() and transferToStream() because they're unused.
--
To view, visit https://gwt-review.googlesource.com/2020
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf40e5c09dc2b9a91c8ae96d8ba79f6f69890410
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Colin Alworth <niloc...@gmail.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
