Brian Slesinsky has posted comments on this change.
Change subject: Refactors StackTraceDeobfuscator as public API.
......................................................................
Patch Set 1:
(3 comments)
The public API seems mostly okay, except that if we're going to clean
things up, I don't think we want to have a lot of subclasses like we did
before. We should change the API so that's no longer necessary.
Also, it's surprising that we got this far without unit tests.
....................................................
File user/src/com/google/gwt/core/server/StackTraceDeobfuscator.java
Line 39: * emulated stack traces, via <code><set-property
name="compiler.stackMode" value="emulated"
Is this comment up to date and should we say something similar in
printStackTrace() in the other CL?
Line 130: * @param symbolMapsDirectory the <code>symbolMaps</code>
directory, with or without trailing
I think we should say a bit more about what we expect to see in this
directory. That is, we expect to see filenames of the form <strong
name>.symbolmap or <strong name>_sourcemap<fragment>.json
Line 308: protected InputStream getSymbolMapInputStream(String
permutationStrongName)
For the old version of this class, there are a large number of subclasses
and the only reason they exist is to override this method and
getSymbolMapInputStream. Perhaps instead, the constructor should take some
kind of FileOpener interface that looks for the appropriate sourcemap file
or symbolmap file?
--
To view, visit https://gwt-review.googlesource.com/2131
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97eafa571fcc597a8a03b8dae4bfc17ea0462e85
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
