Brian Slesinsky has posted comments on this change.
Change subject: Adds two new optional configuration properties to allow the
JsNamer passes to exclude a set of predefined symbols or symbol suffixes in
the output. This is to enable better integration with closure compiler
which has optimization passes that trigger off o
......................................................................
Patch Set 3:
(2 comments)
....................................................
File dev/core/src/com/google/gwt/dev/js/JsNamer.java
Line 131: blacklist.add(ident.trim());
Suppose js.identifier.blacklist.suffixes has a trailing comma. I think that
means we put the empty string in the blacklist and isAvailableIdent()
always returns false. Seems like it might be confusing.
Line 156: if (lcIdent.endsWith(suffix)) {
If a suffix contains any capital letters, it will never match.
--
To view, visit https://gwt-review.googlesource.com/2230
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eb0535cd2c7693aae162e246332dc7bca87d241
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Alan Leung <acle...@gmail.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
