Roberto Lublinerman has posted comments on this change.
Change subject: Remove early optimization from Precompile.
......................................................................
Patch Set 2:
Here are the numbers on two sets of 4 runs.
AVG Before: Pre: 267 Compile: 285 Total: 552
AVG After: Pre: 238 Compile: 310 Total: 548
Not much savings (4 seconds on average). Comparing fastest runs the gains
are 10 seconds.
The surprising part is that the serialized precompilation
(precompilation.ser) is ~10% smaller with the patch.
I think the reason is related to an issue I found recently while debugging
my latests change, and that is that some nodes, e.g. JMethodCall have
targets that are not part of the AST.
The other finding is that if the optimization is left in the precompilation
(as before this patch) the precompilation.ser file is different each time
it is run (that is not the case after the patch). A reason for that maybe
some iteration on a HashSet or HashMap. I'll have a look at that.
--
To view, visit https://gwt-review.googlesource.com/2280
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26bad5f14735a9283021b53edadc5bde1a659c45
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
