Thomas Broyer has posted comments on this change.
Change subject: Issue 6256: getAbsoluteTop/getScrollTop returns wrong
values for IE9 when body has been scrolled * Moved methods that are
specific to WebKit/Safari from DOMImplStandardBase to DOMImplWebkit so that
they don't affect DOMImplIE9 (which currently extends DOM
......................................................................
Patch Set 1:
(6 comments)
....................................................
Commit Message
Line 8: * Moved methods that are specific to WebKit/Safari from
DOMImplStandardBase to DOMImplWebkit so that they don't affect DOMImplIE9
(which currently extends DOMImplStandardBase). There might be other methods
in DOMImplStandardBase that are specific to WebKit/Safari; I moved only
those methods that had comments specifying Safari.
Add a blank line above to please Git
(one-line-summary\n\nmultiline-description)
....................................................
File user/src/com/google/gwt/dom/client/DOMImplWebkit.java
Line 71: public native ButtonElement createButtonElement(Document doc,
String type) /*-{
We no longer enforce it but can you please sort the methods by name?
Line 78: * Safari 2 does not support {@link
ScriptElement#setText(String)}.
I don't think we still support Safari 2: we removed an old hack in
DOMImplWebKit last June, and we removed support in History more than 3
years ago!
http://gwt-code-reviews.appspot.com/29803 said "I also ditched the
no-longer-supported Safari 2 history implementation" (note that it's
specific to "history" though, as it never really worked); unfortunately
Safari 2 is still mentioned in the javadoc despite the code its refererring
to is long gone.
Line 89: // Safari always applies document scrolling to the body
element, even in
BTW is this true of Chrome too? I suppose it's more a WebKit thing
independent of its various "ports", so it'd be the appropriate time to
s/Safari/WebKit/ in those comments.
Line 98: return doc.getBody().getScrollTop();
As we're at it, we might want to revisit this, in light of issue 5836
Line 102: public native int getTabIndex(Element elem) /*-{
nit: trailing space
--
To view, visit https://gwt-review.googlesource.com/2260
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eb89528e534b3b474c60e002ea9d775ca04a796
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Marius Dumitru Florea <mariusdumitru.flo...@xwiki.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
