Goktug Gokdogan has posted comments on this change.
Change subject: Moves GWTTestCase to
Impl#setUncaughtExceptionHandlerForTest.
......................................................................
Patch Set 3:
(5 comments)
....................................................
File user/src/com/google/gwt/junit/client/GWTTestCase.java
Line 350: * This method is called by the test framework to report
uncaught exceptions. The default
I think we should not try specify how uncaught exception are generated
here. I added a @see below for someone who needs to read more about it.
Line 351: * implementation causes test case to be reported as 'failed'
however in some rare situations
Done
Line 352: * where an uncaught exception is expected then test case may
choose to alter the behavior by
Done
Line 362: * if (t instanceof ExpectedUmbrellaException) {
Done
Line 373: * already finished before this method is called, the behavior
is undefined.
Done.
About the additional paragraph: I put more info various places to cover
more aspects, but I think we should not over specify as it makes it harder
to read and ends up confusing the developer.
--
To view, visit https://gwt-review.googlesource.com/2190
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d32c6f4ff4cbcd55f238116b8bcc4c8685d6f35
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
