Brian Slesinsky has posted comments on this change.
Change subject: Refactors c.g.gwt.logging to use SerializableThrowable.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
user/src/com/google/gwt/user/client/rpc/core/java/util/logging/LogRecord_CustomFieldSerializer.java
Line 36: SerializableThrowable thrown = (SerializableThrowable)
reader.readObject();
I'm thinking of what happens when the GWT app is stale compared to the
server. We would get a class cast exception because the old code is still
sending the old SerializableThrowable and the new code is casting it to the
new SerializableThrowable.
Yes, many things won't work in that case, but logging is special in that we
would like logging to work when nothing else works, because we use it to
see the problems.
Perhaps this is just being overly cautious; I don't know how likely it is
to actually help and it will disappear once everyone reloads the page. But
strange things happen when debugging edge cases.
--
To view, visit https://gwt-review.googlesource.com/2310
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeee26a9b36cbe40bd1cf0942da8fae39179e985
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
