Matthew Dempsky has posted comments on this change.
Change subject: Reduce ClassSourceFileComposer memory and time complexity
to O(N)
......................................................................
Patch Set 2:
(1 comment)
....................................................
File user/src/com/google/gwt/user/rebind/ClassSourceFileComposer.java
Line 163: printWriter.print(s.substring(pos, nl + 1));
Done.
I decided to use write() since that's the more primitive method (at least
in OpenJDK's implementation), so it might actually avoid a substring()
call. However, write()'s second integer argument is a length field, not an
end position like substring() and append(), so an extra subtraction is
required.
--
To view, visit https://gwt-review.googlesource.com/2460
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30301a58bad0244a41b08fb534c4cb18b90c9494
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
