Thomas Broyer has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
......................................................................
Patch Set 2:
(3 comments)
Where can I find instructions for how to configure Eclipse
to not automatically add that whitespace back when
formatting the code using the formatter settings included
with the project?
No idea. AFAIK, Eclipse and IntelliJ IDEA insist in using 2 distinct rules.
But the problem is not so much about whether those spaces are there or not,
but more about including only the relevant changes in the patch (i.e. "git
add -p" vs. "git add").
....................................................
File user/test/com/google/gwt/user/client/TimerCancelTest.java
Line 29: private int timerCount;
This field should live in the CountingTimer, which could thus become a
static nested class, and removes the need for the gwtSetUp (which is
probably not needed anyway, even in the current configuration).
Line 51: // Busy wait so that both timers will be added to the event
loop queue the next time it is
Is this really needed? If so, can you please add a comment somewhere
explaining exactly the conditions the issue manifests itself?
Line 97: public String getModuleName() {
Move at the top of the class.
--
To view, visit https://gwt-review.googlesource.com/2511
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Leif Åstrand <l...@vaadin.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Leif Åstrand <l...@vaadin.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
