Roberto Lublinerman has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
......................................................................
Patch Set 3:
(3 comments)
....................................................
File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java
Line 229: void onWildcaredValueChangeList(ValueChangeEvent<List<?>>
event) {
Actually it does not matter. If it has a wildcard then the raw type is
used. Both will work.
....................................................
File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
Line 698: <img src="{values.aUrl}" ui:field='myImage'/>
Done
....................................................
File
user/test/com/google/gwt/uibinder/test/client/WildcardValueChangeWidget.java
Line 40: * Here is the key for the test. ValueChangeHandler is
parameterized by ? and not <T>q
Done
--
To view, visit https://gwt-review.googlesource.com/2470
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcd6ecec455512a7da5eb473c6bf2e9f402f0ea
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
