I experimented with Composite last week. There was no damage in Google3 - at least I didn't notice any. ResizeComposite might have a few but should be easy to fix.
I'll coordinate with Roberto though there shouldn't be any implications related Java 7 as this change is only relates to raw types. On Mon, Apr 29, 2013 at 10:51 AM, Brian Slesinsky <skybr...@google.com>wrote: > As an experiment, perhaps someone can come up with another patch that adds > type parameters to Composite and ResizeComposite and we can run Google's > tests to see what the damage is. > > We can start on it now, but before making a final decision we should > probably wait until Roberto is done upgrading the JDT, since type-checking > is stricter in Java 7 and it might make a difference. > > > > On Sat, Apr 27, 2013 at 4:32 AM, Jens <jens.nehlme...@gmail.com> wrote: > >> So what is the gotcha? >>> >> >>> First of all old code will give warnings due to missing generic type in >>> Composite. Also classes that doesn't need to enhance the type information >>> will still need to provide a type for Composite, this includes most of the >>> Composite uses with the UIBinder. >>> >> >> GPE should be updated to use "extends >> Composite<UiBinderRootWidgetTypeHere>" if it detects a GWT SDK that >> supports it. And IntelliJ's generated code for UiBinder files current >> doesn't even add "extends Composite" out of the box. You would need to >> configure IntelliJ's UiBinder File Template for doing so and thus you could >> easily change it to at least Composite<Widget> or maybe even >> Composite<UiBinderRootWidgetTypeHere>. >> >> >> We can get mitigate these problems by introducing a separate >>> 'TypedComposite' and 'TypedResizeComposite' class that uses generics. Of >>> course this means more classes that will potentially cause more confusion. >>> >> >> I am against TypedComposite, TypedResizeComposite. Beside the fact that >> they confuse a bit you probably will make Composite and ResizeComposite >> deprecated either now or in the future. And once you remove deprecated >> Composite/ResizeComposite from the code base you end up with two classes >> with bad names. >> >> I would expect Composite and ResizeComposite to be typed and not having >> classes with names that tell me that they are typed. So I am with Thomas >> here and would vote for just making Composite/ResizeComposite generic even >> if it means a lot of warnings in current code bases. IMHO these warnings >> are better than having two strangely named classes in the future. >> >> -- J. >> >>> -- >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> --- >> You received this message because you are subscribed to the Google Groups >> "Google Web Toolkit Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > > -- > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > --- > You received this message because you are subscribed to the Google Groups > "Google Web Toolkit Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
