Goktug Gokdogan has posted comments on this change.
Change subject: Add SafeUri overloads for setting properties used for
navigation
......................................................................
Patch Set 4:
Actually I'm not much concerned about the breaking part, it is an easy fix
and there is not so many uses of it.
I'm more concerned about the API. Setting to null is a valid use case;
currently there is no other way to revert the element back to its initial
state; it is different then setting it to empty or anything else. Most of
internal uses was basically using null to reverting the href.
Also If you look at dom.client package, only previous safe setXXX method is
the Element#setInner*Safe*Html. This is also inconsistent with that.
I think it is better to change this before people starts using it.
--
To view, visit https://gwt-review.googlesource.com/2663
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ab7a472b0c0c4470f00f7178de216f7c7e4e415
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Guillaume Ryder <gry...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Patrick Tucker <tucker...@gmail.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
