Thomas Broyer has posted comments on this change.
Change subject: Use JSON.parse() instead of eval() to deserialize rpc
callback payload
......................................................................
Patch Set 3: -Code-Review
(1 comment)
That starts to look good.
As discussed previously, I think we should bump the protocol version, and
conditioning the server output (whether to use the .concat hack or not) the
request version should be easy (in
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java,
there's already something about long serialization).
We could also just punt to when we remove support for IE6/7. The, we can
either bump the protocol version again (version 9 would be identical to 8
except for the absence of the .concat hack) or change clients to throw an
IncompatibleServiceException (but then stale clients running in IE6/7 will
choke on deserialization of big arrays; not really a problem right?)
....................................................
File user/src/com/google/gwt/core/client/JsonUtils.java
Line 129: public static native boolean hasJsonParse() /*-{
We should rather add an accessor for the static field (e.g.
hasNativeJsonParse)
As an alternative, maybe we could use JSNI to access this field and keep it
private. This is hack, but it's only temporary until we remove support for
IE6/7 (where we could unconditionally use JsonUtils.safeEval(), and that
one would unconditionally use JSON.parse, and that field would disappear).
Given that hasNativeJsonParse would soon unconditionally return 'true', I'd
prefer that we don't introduce such an API in 2.6 that we'll deprecate as
soon as 3.0.
--
To view, visit https://gwt-review.googlesource.com/2900
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos <j...@vaadin.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Colin Alworth <niloc...@gmail.com>
Gerrit-Reviewer: John Ahlroos <j...@vaadin.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
