Thomas Broyer has posted comments on this change.
Change subject: Cut circular dependency between c.g.g.core.linker and
c.g.g.dev.js
......................................................................
Patch Set 1:
(1 comment)
....................................................
File dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java
Line 109: *
Eclipse and IntelliJ disagree about what counts as "spaces at the end of
the line" in comments; or rather about what is the "prefix" for multiline
comments: in Eclipse, multiline comments are lines prefixed an
indented "* " (the space is part of the prefix, it's not considered "end of
line"; it's there to somehow "align" everything).
I don't think we want to make a hard rule about that, unless someone finds
a way to make Eclipse and IntelliJ behave the same (and I'm not even
talking about NetBeans).
We'll have to have that discussion at some point, so feel free to start it
on gwt-contrib.
--
To view, visit https://gwt-review.googlesource.com/1031
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id33cdf94725981c9c5779553444c1ac64659892c
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer <t.bro...@gmail.com>
Gerrit-Reviewer: Manuel Carrasco Moñino <manuel.carrasc...@gmail.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
