James Nelson has posted comments on this change.
Change subject: Adds support for lower case encoding names to String
......................................................................
Patch Set 2:
(1 comment)
lgtm;
made a nit for production mode performance (using native js regex), though
I'm not sure it's worth it.
....................................................
File user/super/com/google/gwt/emul/java/lang/String.java
Line 309: if (CHARSET_UTF8.equalsIgnoreCase(charset)) {
I wonder if we might see better performance using native methods w/ js
regex.
native boolean isUtf8(String charset)
/*-[
return (charset||'').match(/utf-8/i)
]-*/;
--
To view, visit https://gwt-review.googlesource.com/3000
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9532ba1e7e6e863093727e354f7f3174229c2ab
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Honza Rameš <rame...@gmail.com>
Gerrit-Reviewer: Honza Rameš <rame...@gmail.com>
Gerrit-Reviewer: James Nelson <ja...@wetheinter.net>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
