Thomas Broyer has posted comments on this change.
Change subject: Adding Integer.compare to emulation
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
How about Short.compare() and similar?
....................................................
Commit Message
Line 9: fixes ISSUE 7998
Can you put "issue" in lowercase so Gerrit links it to the issue tracker?
Also, using a "Bug: " line in the footer (next to Change-Id, with no blank
line between them) allows you to search for all reviews related to that bug
with the "tr:" keyword; e.g.
https://gwt-review.googlesource.com/#/q/tr:4847,n,z (we should document
that in makinggwtbetter)
--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: John A. Tamplin <j...@jaet.org>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
