Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
......................................................................
Patch Set 6:
(4 comments)
....................................................
File user/super/com/google/gwt/emul/java/util/Arrays.java
Line 414: static boolean deepEquals0(Object obj1, Object obj2) {
comments from patch set 3 still not addressed.
....................................................
File user/super/com/google/gwt/emul/java/util/Objects.java
Line 36: return (a == b) || (a != null && a.equals(b));
Comment from patch set 3 still not addressed.
....................................................
File user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
Line 38: return 0;
Replace with a call to fail() as Objects.compare() shouldn't call the
comparator if that's the case.
Line 88: public void testEquals() {
Maybe add a test with the second argument being null, testing that the
first argument's equals() is *not* called (either make it's equals() return
true for null, or call fail()):
assertFalse(Object.equals(new Object() {
@Override
public boolean equals(Object other) {
fail("Shouldn't call equals if second argument is null");
}
}, null));
--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy <a.korzhevs...@gmail.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: John A. Tamplin <j...@jaet.org>
Gerrit-Reviewer: Ray Cromwell <cromwell...@gmail.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
