Thomas Broyer has posted comments on this change.
Change subject: Change DOM access in HTMLTable for IE
......................................................................
Patch Set 2:
(2 comments)
Should we rather move that to c.g.g.dom (Table*Element have .rows
and .cells) and rewrite the JSNI in HTMLTable to use the c.g.g.dom JSO
wrappers?
Also, what would it do if we used the IE implementation everywhere? (IIRC,
children might contain text nodes in other browsers whereas IE only
includes elements there, and that would break in non-IE browsers then; am I
right?)
....................................................
File user/src/com/google/gwt/user/HTMLTable.gwt.xml
Line 2: <!-- Copyright 2007 Google
Inc. -->
2013
Line 23: <!-- Fall through to this rule is the browser isn't IE -->
typo: is → if
Also, I'm not a native-English speaker, but I think it should be "fall
back" here rather than fall through.
--
To view, visit https://gwt-review.googlesource.com/3212
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5789589a307f457a1295b9ed72111ad4c040fa97
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
