I am very much in favor of moving things forward with breaking changes as long as we can see most of the damage up front.
Let me check internally if we can find out if Johns concerns are valid so we might be able to implement this much simpler. On Thu, Jun 6, 2013 at 9:05 AM, David <[email protected]> wrote: > Hi, > > If you ask me, not serializing the final field was more a bug than a > feature. (I know, GWT RPC is not the same as Java serialization) > > Do I need to enable something to get warnings on final fields not being > serialized in 2.5.1 or is that standard behaviour. > > I am a very active user of the final keyword since it allow my IDE and > Java compiler to warn me when I forget to initialize it. So I am a bit > suprised that I did not see any warnings yet. > > David > > On Thu, Jun 6, 2013 at 7:36 AM, Stephen Haberman <[email protected] > > wrote: > >> >> > Does having the flag really make it that much more complicated? >> >> It would not seem like it, but yes. :-) >> >> Specifically passing the context down through the layers to the right >> spot to say "do I serialize final fields?" took a bit--one of the first >> patches that went by used a static field to avoid a lot of method >> signatures, but it assumed only one GWT module/setting running at a >> time. >> >> It was also complicated by having to play nicely with the current "warn >> on finalize field" flag. >> >> Both of these are trivial in the big scheme of GWT-RPC, but every >> little simplification helps. >> >> - Stephen >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> --- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> >> > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > --- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- Google Germany GmbH *Dienerstr. 12* *80331 München* Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
