Thomas Broyer has posted comments on this change.
Change subject: Real branched logger is passed to the
ResourceOracleImpl.refresh() method instead of TreeLogger.NULL
......................................................................
Patch Set 2:
(4 comments)
An alternative would be to reintroduce a TreeLogger argument to the
refresh() method (it was removed when the lazyResourceOracle was
introduced), store it along with the needsRefresh flag, and later use it in
doRefresh. And maybe also add a TreeLogger argument to getResourcesOracle.
That way, the log is in the branch for the code that called refresh(),
rather than repeatedly appended to the branch for the code that created the
ModuleDef.
....................................................
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
Line 408: lazyResourcesOracle = new
ResourceOracleImpl(TreeLogger.NULL, resources);
Any reason that one is still NULL? (I have no single idea what it is used
for)
Line 419: logger.branch(Type.DEBUG, "Computing available "
+ "resources for resource oracle");
No need for the concatenation (I suspect auto-format played with your code;
auto-format is evil)
Line 592: TreeLogger refreshLogger = TreeLogger.NULL;
Could you factor this into a getRefreshLogger method?
....................................................
File dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java
Line 152: Event moduleDefLoadFromClassPathEvent =
Please avoid reformats that are independent from the issue being fixed.
(either disable auto-format or use an interactive "git add")
--
To view, visit https://gwt-review.googlesource.com/3381
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c0417882b002d12eb1c5e98ce865607a78a682a
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Denis Anisimov <de...@vaadin.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
