Daniel Kurka has posted comments on this change.
Change subject: Adds Timer#isRunning().
......................................................................
Patch Set 2:
(3 comments)
....................................................
File user/src/com/google/gwt/user/client/Timer.java
Line 110: throw new IllegalArgumentException("must be non-negative");
can we unify the IllegalArgumentExceptions in schedule and
scheduleRepeating as well?
< 0 vs. <=0
Line 151:
Shouldn't timer.isRunning be true if the timer code is executing. How about
we defer update until after run has been called?
Maybe even add a test for this
....................................................
File user/test/com/google/gwt/user/client/TimerTest.java
Line 86: // Issue
https://code.google.com/p/google-web-toolkit/issues/detail?id=8101
I am not sure if this sufficiently tests fur bug 8101.
To me this reads like IE must have added the timer to the event loop
already, so I think we actually need a busy wait here to test for that
--
To view, visit https://gwt-review.googlesource.com/3321
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
