Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
......................................................................
Patch Set 9:
@Andrey: thanks; but no need to create a new issue here, it's the
continuity of the original issue (and fixing failing tests / failing builds
shouldn't need an issue filed generally speaking)
@Matthew & Goktug: OK. We should write it somewhere I think.
Actually, I think we should write out how we want to run code reviews: does
+2 really means "ready to merge"? who should merge? the person giving the
+2 or the submitted –if he can, of course–? For instance, Daniel gave a +2
and merged one of Goktug's change before he could test the implications
Ia3e4870e85ea5825bfbd1ccef6c635a4b331601c, so it was later reverted
Id162c4e9b553a5981f09d26a3d1112dbf085825e; stating somewhere that Goktug
should have given his review a -1 or -2 until he tested the implications of
the change would have prevented it. Do you have such a doc already inside
Google that could be used as a first draft?
--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy <a.korzhevs...@gmail.com>
Gerrit-Reviewer: Andrey Korzhevskiy <a.korzhevs...@gmail.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: John A. Tamplin <j...@jaet.org>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@gmail.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
