[gwt-contrib] Change in gwt[master]: Make Element.hasTagName(...) case-insensitive.

[Thomas Broyer]

Thomas Broyer has submitted this change and it was merged.
Change subject: Make Element.hasTagName(...) case-insensitive.
......................................................................


Make Element.hasTagName(...) case-insensitive.

Helpful because the various Element TAG constants are in lower-case, but
Element.getTagName() returns upper-case.

Fixes issue 7756.

Change-Id: Ib24bee7fa494c0345a7bc97e1b5df1095a05d024
---
M user/src/com/google/gwt/dom/client/Element.java
M user/test/com/google/gwt/dom/client/ElementTest.java
2 files changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Leeroy Jenkins: Verified
  Thomas Broyer: Looks good to me, approved



diff --git a/user/src/com/google/gwt/dom/client/Element.java  
b/user/src/com/google/gwt/dom/client/Element.java
index f8768e4..c801f5d 100644
--- a/user/src/com/google/gwt/dom/client/Element.java
+++ b/user/src/com/google/gwt/dom/client/Element.java
@@ -514,7 +514,7 @@
    */
   public final boolean hasTagName(String tagName) {
     assert tagName != null : "tagName must not be null";
-    return tagName.equals(getTagName());
+    return tagName.equalsIgnoreCase(getTagName());
   }

   /**
diff --git a/user/test/com/google/gwt/dom/client/ElementTest.java  
b/user/test/com/google/gwt/dom/client/ElementTest.java
index 907f736..911d788 100644
--- a/user/test/com/google/gwt/dom/client/ElementTest.java
+++ b/user/test/com/google/gwt/dom/client/ElementTest.java
@@ -356,6 +356,18 @@
     assertFalse(div.hasAttribute(null));
   }

+  public void testHasTagName() {
+    DivElement div = Document.get().createDivElement();
+
+    // hasTagName is case-insensitive
+    assertTrue(div.hasTagName("div"));
+    assertTrue(div.hasTagName("DIV"));
+    assertTrue(div.hasTagName(DivElement.TAG));
+    assertTrue(div.hasTagName(div.getTagName()));
+
+    assertFalse(div.hasTagName("dove"));
+  }
+
   /**
    * Tests HeadingElement.as() (it has slightly more complex assertion  
logic
    * than most).

--
To view, visit https://gwt-review.googlesource.com/2975
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib24bee7fa494c0345a7bc97e1b5df1095a05d024
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roy Paterson <roy.pater...@gmail.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Manuel Carrasco Moñino <manuel.carrasc...@gmail.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Roy Paterson <roy.pater...@gmail.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.