In my opinion, having the tool-bar in gwt makes perfectly sense, RichTextArea is almost unusable without a bar in any project. It's plenty of gwt projects which have copied and pasted the code from the showcase.
I think that you should face this issue in some steps: 1.- Listen to GWT contributors for the convenience of moving RichTextToolbar from samples to gwt. So maintain live this thread until you get enough feedback. 2.- Send a first patch just moving the code from show-case to gwt (showcase should use the new code) 3.- When the patch were accepted, continue adding other features like adding/removing widgets from the toolbar, or a panel grouping RichTextArea + RichTextToolbar, etc. because each thing needs a different review/discussion. - Manolo On Tue, Jun 11, 2013 at 7:25 PM, Adolfo Panizo Touzon <adolfo.pan...@gmail.com> wrote: > Oh! Sorry I saw you were the owner and I thought you had plenty of > responsability. > > Thanks, but everything is fine, the installation process is quite > simple/clear, so, all is up and running. :D. > > Keep an eye into the Issue 1127 because maybe you are interested in giving > instructions related to both issues. > > Thanks, > > Adolfo. > > > On Tue, Jun 11, 2013 at 10:28 AM, Daniel Kurka <danku...@google.com> wrote: >> >> Hi Adolfo, >> >> this is not my issue and I am not solely responsible for it. >> >> We should see wait and see if anybody opposes to adding this to GWT, >> before you actually start working on it, so that your time will not be >> wasted. >> On the other hand you can already setup your IDE and tools to be able to >> start. James pointed out the resources. If there is anything wrong / unclear >> in those resources please let us know. Or you could even send a patch for >> the homepage to be updated. >> >> - Daniel >> >> >> On Mon, Jun 10, 2013 at 8:07 PM, Adolfo Panizo Touzon >> <adolfo.pan...@gmail.com> wrote: >>> >>> Thanks James! >>> >>> But I have done those steps yet (indeed I read in that link I should ask >>> here first :D) . When I said the necessary work I meant the steps for >>> develop the RichTextArea according to the GWT steering committee (for this >>> issue I think Daniel is responsible) so I need to wait for his opinion. >>> >>> Thanks anyway for your quick response. >>> >>> Adolfo. >>> >>> >>> On Mon, Jun 10, 2013 at 1:02 PM, James Horsley <james.hors...@gmail.com> >>> wrote: >>>> >>>> Adolfo, >>>> >>>> To get the source checked out and compiling follow: >>>> http://www.gwtproject.org/makinggwtbetter.html#workingoncode >>>> >>>> To submit the patch use: >>>> http://www.gwtproject.org/makinggwtbetter.html#submittingpatches >>>> >>>> I recently had to move an old svn patch into gerrit and the following >>>> gave a very simple way to apply it >>>> http://stackoverflow.com/questions/659467/how-to-apply-svn-diff-to-git just >>>> remember to clean up any leftover .orij and .rej files. >>>> >>>> Cheers, >>>> James >>>> >>>> >>>> On 10 June 2013 10:01, Adolfo Panizo <adolfo.pan...@gmail.com> wrote: >>>>> >>>>> Hi, >>>>> >>>>> as I wrote in the issue, I am able to do the necessary work for solving >>>>> it. So, can you guide me about the steps that I need to follow in order >>>>> to >>>>> create a patch properly? >>>>> >>>>> Would you like to reuse some code of the old patch? >>>>> >>>>> I am going to contact the creator of it because maybe he continues >>>>> interested on fixing the issue and rebase the patch with the last code. >>>>> >>>>> Of course if there are other issues related to RichTextArea I can solve >>>>> as well. >>>>> >>>>> Thanks in advance, >>>>> >>>>> Adolfo. >>>>> >>>>> >>>>> -- >>>>> http://groups.google.com/group/Google-Web-Toolkit-Contributors >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "GWT Contributors" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >>>>> For more options, visit https://groups.google.com/groups/opt_out. >>>>> >>>>> >>>> >>>> >>>> -- >>>> http://groups.google.com/group/Google-Web-Toolkit-Contributors >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "GWT Contributors" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >>>> For more options, visit https://groups.google.com/groups/opt_out. >>>> >>>> >>> >>> >>> >>> >>> -- >>> El precio es lo que pagas. El valor es lo que recibes. >>> Warren Buffet >>> >>> -- >>> http://groups.google.com/group/Google-Web-Toolkit-Contributors >>> --- >>> You received this message because you are subscribed to the Google Groups >>> "GWT Contributors" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/groups/opt_out. >>> >>> >> >> >> >> >> -- >> Google Germany GmbH >> Dienerstr. 12 >> 80331 München >> >> Registergericht und -nummer: Hamburg, HRB 86891 >> Sitz der Gesellschaft: Hamburg >> Geschäftsführer: Graham Law, Katherine Stephens >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> --- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/groups/opt_out. >> >> > > > > > -- > El precio es lo que pagas. El valor es lo que recibes. > Warren Buffet > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > --- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
