Daniel Kurka has posted comments on this change.
Change subject: making RootPanel.clear(true) respects GWT loader iframei
......................................................................
Patch Set 1:
(2 comments)
....................................................
File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 329: if (!shouldNodeBeRemoved(child)) {
If I don't remove them we will see the same node in the next iteration and
since iterating this way is the fastest way to do it. I am okay with
reatttaching an element.
Line 346: && GWT.getModuleName().equals(childElement.getId())) {
You are right this will break IE6 History, but I am not willing to add
extra complexity just to keep IE6 happy, since this will get released with
GWT 2.6, its fine.
--
To view, visit https://gwt-review.googlesource.com/3430
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If876b04c453a1d4e170870e97f3a82d0d86599d5
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Manuel Carrasco Moñino <manuel.carrasc...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
