Matthew Dempsky has posted comments on this change.
Change subject: FileUpload: extending FocusWidget instead of Widget so as
it exposes many features which already are in the file-input element:
click(), focus(), mouseevents, keyevents, etc.
......................................................................
Patch Set 5:
(2 comments)
....................................................
File user/src/com/google/gwt/user/client/ui/FileUpload.java
Line 44: * The developer should be aware that most browsers do not allow
to style
"do not allow to style" here sounds funny to me. Maybe "do not allow
styling"?
Line 209: public void click() {
Is "click" the best name for this method? Maybe something more explicitly
explaining why the user would want to call it,
like "openFileSelectionDialog()"?
--
To view, visit https://gwt-review.googlesource.com/3211
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Manuel Carrasco Moñino <manuel.carrasc...@gmail.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Manuel Carrasco Moñino <manuel.carrasc...@gmail.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Patrick Tucker <tucker...@gmail.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
