Goktug Gokdogan has posted comments on this change.
Change subject: adds regression testing against future changes that might
accidentally push all fragment code into the leftover fragment
......................................................................
Patch Set 5: Code-Review+2
(3 comments)
....................................................
Commit Message
Line 7: adds regression testing against future changes that might
accidentally push all fragment code into the leftover fragment
Can you use a shorter first line if possible?
If you can't, then can you wrap the line?
....................................................
File user/src/com/google/gwt/core/client/impl/LoadingStrategyBase.java
Line 114:
nit: spaces
....................................................
File user/test/com/google/gwt/dev/jjs/test/LoggingXhrLoadingStrategy.java
Line 49: super.tryDownload(new
com.google.gwt.core.client.impl.LoadingStrategyBase.RequestData(
I guess you don't need to use FQN.
--
To view, visit https://gwt-review.googlesource.com/3590
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Stalcup <stal...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: John Stalcup <stal...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
