Brian Slesinsky has posted comments on this change.
Change subject: Super Dev Mode: deemphasize unused Java lines in
codeserver's UI
......................................................................
Patch Set 1:
(7 comments)
....................................................
File dev/codeserver/java/com/google/gwt/dev/codeserver/ReverseSourceMap.java
Line 1: package com.google.gwt.dev.codeserver;
Done
Line 12: private final SourceMapConsumerV3 consumer;
Not wild about it but I don't have a better name.
Line 20: * If it can't be loaded, logs an error and returns null.
Done
Line 29: logger.log(TreeLogger.WARN, "can't parse source map", e);
This class is package-local and it's only used in one place, so I think
it's okay to specialize it to make the calling code cleaner. If we ever
reuse it, we can generalize it.
But there was a bug because the caller didn't check for null. Fixed by
changing load() to return an empty source map instead of null.
....................................................
File dev/codeserver/java/com/google/gwt/dev/codeserver/SourceHandler.java
Line 189: private void sendSourceFileAsHtml(String moduleName, String
fileName, BufferedReader lines,
If this were a public API then from a "what's the contract with the caller"
perspective, all that matters is that it sends an HTTP response. But since
this isn't a public API and there's only one caller, I'd rather explain
what it actually does.
Line 194: File file = new File(fileName);
Done. Went with "sourcePath" since it's actually a path.
Line 200: out.startTag("html").nl();
We don't currently have a server-side templating library as a GWT
dependency and I decided to avoid adding one. (Anything we use should do
auto-escaping to protect against XSS.)
--
To view, visit https://gwt-review.googlesource.com/3600
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id16bcd2287630cebf7afb8bbbe0a198b28f5ada9
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: John Stalcup <stal...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
