[gwt-contrib] Change in gwt[master]: Let ValueListBox implement HasEnabled

[Thomas Broyer]

Thomas Broyer has submitted this change and it was merged.
Change subject: Let ValueListBox implement HasEnabled
......................................................................


Let ValueListBox implement HasEnabled

fixes issue 6112

Change-Id: Ib866657960d0a3d41e0b3b1f08fa9a97091149a9
---
M user/src/com/google/gwt/user/client/ui/ValueListBox.java
M user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
2 files changed, 20 insertions(+), 1 deletion(-)

Approvals:
  Leeroy Jenkins: Verified
  Thomas Broyer: Looks good to me, approved



diff --git a/user/src/com/google/gwt/user/client/ui/ValueListBox.java  
b/user/src/com/google/gwt/user/client/ui/ValueListBox.java
index 1bdbdf8..61f6f85 100644
--- a/user/src/com/google/gwt/user/client/ui/ValueListBox.java
+++ b/user/src/com/google/gwt/user/client/ui/ValueListBox.java
@@ -42,7 +42,8 @@
  * @param <T> the value type
  */
 public class ValueListBox<T> extends Composite implements
-    Focusable, HasConstrainedValue<T>, IsEditor<TakesValueEditor<T>> {
+    Focusable, HasConstrainedValue<T>, HasEnabled,
+    IsEditor<TakesValueEditor<T>> {

   private final List<T> values = new ArrayList<T>();
   private final Map<Object, Integer> valueKeyToIndex = new HashMap<Object,  
Integer>();
@@ -97,6 +98,11 @@
     return value;
   }

+  @Override
+  public boolean isEnabled() {
+    return getListBox().isEnabled();
+  }
+
   public void setAcceptableValues(Collection<T> newValues) {
     values.clear();
     valueKeyToIndex.clear();
@@ -116,6 +122,11 @@
   }

   @Override
+  public void setEnabled(boolean enabled) {
+    getListBox().setEnabled(enabled);
+  }
+
+  @Override
   public void setFocus(boolean focused) {
     getListBox().setFocus(focused);
   }
diff --git a/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java  
b/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
index bc6384e..714de32 100644
--- a/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
+++ b/user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
@@ -65,6 +65,14 @@
     return "com.google.gwt.user.User";
   }

+  public void testEnabled() {
+    subject.setEnabled(true);
+    assertTrue(subject.isEnabled());
+
+    subject.setEnabled(false);
+    assertFalse(subject.isEnabled());
+  }
+
   public void xx_testExtraValueSet() {  // TODO(rjrjr) Strange failures on  
firefox
     Foo[] values = new Foo[] {new Foo("able"), new Foo("baker")};
     Foo baz = new Foo("baz");

--
To view, visit https://gwt-review.googlesource.com/3611
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib866657960d0a3d41e0b3b1f08fa9a97091149a9
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Jens Nehlmeier <jens.nehlme...@gmail.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.