Yep sorry it is in CssResourceGenerator line 266 And there is a TODO at line 347 : TODO: Fix the compiler to better handle arbitrarily long concatenation expressions.
So I was just wondering if something was done or not. On Wednesday, October 30, 2013 9:23:02 PM UTC+1, John Stalcup wrote: > > oh you mean in CssResourceGenerator.java > > found it, taking a look > > > On Wed, Oct 30, 2013 at 1:22 PM, John Stalcup <sta...@google.com<javascript:> > > wrote: > >> can you link me to that comment? i'm unfamiliar. >> >> >> On Wed, Oct 30, 2013 at 1:10 PM, Julien Dramaix >> <julien....@gmail.com<javascript:> >> > wrote: >> >>> Dear GWT lovers, >>> >>> I have a question for the compiler guys : in the CssResource I see a >>> comment mentioning that very large string concatenation expressions using >>> '+' cause the GWT compiler to overflow the stack due to deep AST nesting. >>> So it's preferable to use intermediate concatenation groupings in order to >>> force the AST to be more balanced. >>> >>> I'm just wondering if this issue is still present with the actual >>> version of the compiler or if it was fixed to better handle large >>> concatenation ? >>> >>> Thanks, >>> >>> Julien >>> >>> -- >>> http://groups.google.com/group/Google-Web-Toolkit-Contributors >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "GWT Contributors" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to >>> google-web-toolkit-contributors+unsubscr...@googlegroups.com<javascript:> >>> . >>> For more options, visit https://groups.google.com/groups/opt_out. >>> >> >> > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
