It looks quite safe with the tests in place and didn't break anything internally. On the other hand, this is not a regression nor a bug so Thomas and you should decide if you would like to open the door for such patches in this release :)
On Mon, Apr 7, 2014 at 11:38 AM, Daniel Kurka <danku...@google.com> wrote: > I am really not sure if we want to include any other changes than easy > bugfixes here. > > @goktug since you reviewed the change what do you think about possible > breakages? > > > > > On Mon, Apr 7, 2014 at 5:49 PM, Stephen Haberman < > stephen.haber...@gmail.com> wrote: > >> Hi Daniel, >> >> > If you want to get your changes into GWT 2.6.1, they need to get in >> > before Friday. >> >> Selfishly, our app is depending on this patch now: >> >> https://gwt-review.googlesource.com/#/c/6780/ >> >> I know it's not a bug fix, but it's pretty simple; I assume it's find >> to cherry pick into 2.6.1? I can go ahead and do that if so (I assume >> it's for the release/2.6 branch?). >> >> I can also make an issue for it in the tracker so that it shows up in the >> release notes... >> >> Thanks, >> Stephen >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> --- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Google Germany GmbH > *Dienerstr. 12* > *80331 München* > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Katherine Stephens > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
