The problem with implementing clone() at object is that it is an breaking change because of the rules for JSOs. JSOs are required to implement (and declare final) all Object methods because there is no dynamic dispatch. So having clone() at Object implies either implementing it in JavaScriptObject (and declare it final there), breaking all projects that have JSOs that implement clone() or required all JSOs to implement clone() again breaking all projects that have JSOs.
On Mon, May 26, 2014 at 8:10 AM, 'Daniel Kurka' via GWT Contributors < google-web-toolkit-contributors@googlegroups.com> wrote: > I rolled the patch because it broke internal apps and it seemed to hard > and not worthwhile to clean this up. > I just imported the change and running some tests internally I get back > once I can see what needs to be done. > > > On Mon, May 26, 2014 at 11:37 AM, Rocco De Angelis <rdeangeli...@gmail.com > > wrote: > >> Hi all, >> >> I would like to added a clone method to the java.lang.Object class in the >> GWT SDK which simply throws a CloneNotSupportedException. >> This makes it possible to implement the clone method in subclasses. >> See: https://gwt-review.googlesource.com/#/c/6035/ >> >> Daniel Kurka has already done a similar patch but without an adaption of >> GenerateJavaScriptAST.java<https://gwt-review.googlesource.com/#/c/6035/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java> >> class. >> My patch is already in the review system but still not approved. >> Thomas Broyer started with the review and asked me why the patch of >> Daniel was reverted. >> I think that Daniel simply forgot the changes in the >> GenerateJavaScriptAST.java<https://gwt-review.googlesource.com/#/c/6035/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java> >> . >> Some feedback would be nice :) >> >> BR >> Rocco >> >> >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/google-web-toolkit-contributors/b2d067e8-f9c1-4fca-ab10-911e966b09f1%40googlegroups.com<https://groups.google.com/d/msgid/google-web-toolkit-contributors/b2d067e8-f9c1-4fca-ab10-911e966b09f1%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Google Germany GmbH > *Dienerstr. 12* > *80331 München* > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Katherine Stephens > > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/CALLujiovq8QnUqyF0a9wZU7ydzqFwpp0Yg72SibBaW7GKt%2BR%3Dg%40mail.gmail.com<https://groups.google.com/d/msgid/google-web-toolkit-contributors/CALLujiovq8QnUqyF0a9wZU7ydzqFwpp0Yg72SibBaW7GKt%2BR%3Dg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAC7T7gmdfh9AWd5%3D3bRNRzF_Os0bhKg1C4KPE0%2BiZtdnvNRQzA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
