That's fair. I wasn't expecting much need either but just wanted a simpler way out if it ended up being important for the community.
On Wed, Feb 17, 2016 at 11:57 PM, Manuel Carrasco Moñino <man...@apache.org> wrote: > I follow, but I have a couple of thoughts > > - Is it actually useful from the user perspective to use a sourceLevel=1.7 > if he has to manually provide a compatible gwt-jre-emulation? > IMO, he might want that everything works out-of-the-boxy. Right now, gwt > emul classes in the 2.8-snapshot make fail sourceLevel=1.7 though, so I > don't see any reason to deliver gwt-2.8.0 with a non working flag. > > - IMHO, for real users having to code in 1.7, it's not a problem to set > javac.source=1.7 and have gwtc.sourceLevel=default=1.8. In this case the > javac compiler will validate his source code and gwtc compiler does not > need to do the validation, it simply works without raising any error when > processing its internal jre-emul classes. > > So, since gwtc can be run with a sdk7 (even with gwt java8 sources), there > should not be any problem compiling gwt projects written in java7 and > compiled with sdk7, and the user does not bother about the sourceLevel flag. > > > > On Wed, Feb 17, 2016 at 9:13 PM, 'Goktug Gokdogan' via GWT Contributors < > google-web-toolkit-contributors@googlegroups.com> wrote: > >> I think you didn't understand what I said. Let me try to clarify: >> >> "For any reason, if community wants to run the GWT 2.8 SDK in Java 7 >> source level *(i.e. gwtc sourcelevel 7)*, they can theoretically do it >> by supplying *a java7 compatible JRE emulation* without any compiler/SDK >> changes *(but just setting the gwtc sourcelevel 7)*. That's why I didn't >> originally remove Java7 option from the SourceLevel flag. >> By removing the flag (which seems submitted now), the community will not >> have that option *(i.e. they need also supply a modified compiler >> together with the emulation)*." >> >> This may never happen but keeping the flag was cheap so I kept it. >> >> On Tue, Feb 16, 2016 at 11:35 PM, Manuel Carrasco Moñino < >> man...@apache.org> wrote: >> >>> Removing the 1.7 flag does not make the compiler fail when using a java7 >>> sdk. >>> Now the compiler always thinks that source code is sourced-level 1.8 so >>> it does not fail when looking at java8 emul classes. >>> >>> You can still have the java.source property set to 1.7 when compiling >>> your project and javac will validate that your code is java7 compliant, >>> because javac process your client code. >>> >>> In summary javac and gwtc could use at the same time different source >>> languages, but we always need to force gwtc to use 1.8 since new java8 api >>> emul code. >>> >>> >>> On Wed, Feb 17, 2016 at 2:32 AM, 'Goktug Gokdogan' via GWT Contributors >>> <google-web-toolkit-contributors@googlegroups.com> wrote: >>> >>>> To remind the backlog of this: >>>> >>>> GWT 2.8 decided to support only Java8 source level (see related threads >>>> from last year) as the emulation will include Java 8 APIs which cannot be >>>> compiled in Java7 mode. >>>> >>>> However, GWT compiler itself is intended to be runnable in a Java 7 >>>> JVM. This should enable slow-to-upgrade enterprises business to keep their >>>> legacy dev environments. >>>> For any reason, if community wants to run the GWT 2.8 SDK in Java 7 >>>> source level, they can theoretically do it by supplying a java7 compatible >>>> JRE emulation without any compiler/SDK changes. That's why I didn't >>>> originally remove Java7 option from the SourceLevel flag. >>>> By removing the flag (which seems submitted now), the community will >>>> not have that option. >>>> >>>> (It is not import from Google side; just wanted to let you know if the >>>> community cares about it.) >>>> >>>> On Mon, Feb 15, 2016 at 5:12 AM, Thomas Broyer <t.bro...@gmail.com> >>>> wrote: >>>> >>>>> >>>>> >>>>> On Monday, February 15, 2016 at 11:39:02 AM UTC+1, Thomas Broyer wrote: >>>>>> >>>>>> >>>>>> >>>>>> On Monday, February 15, 2016 at 10:06:47 AM UTC+1, Manuel Carrasco >>>>>> Moñino wrote: >>>>>>> >>>>>>> Thomas, I want to experiment with this, pls, could you give me some >>>>>>> advise what are the classes I have to look at? >>>>>>> >>>>>> >>>>>> https://gwt-review.googlesource.com/14353 >>>>>> (currently running the testsuite locally) >>>>>> >>>>> >>>>> Tests pass \o/ >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "GWT Contributors" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to >>>>> google-web-toolkit-contributors+unsubscr...@googlegroups.com. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/google-web-toolkit-contributors/a96d8bde-37f5-4bdd-92f2-7fda3492cc94%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/a96d8bde-37f5-4bdd-92f2-7fda3492cc94%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "GWT Contributors" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to >>>> google-web-toolkit-contributors+unsubscr...@googlegroups.com. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2BRAZ1%2Bu33NNK%2BgqNdijZs7a0V7YY4fasWCes2iGJ%2Bvg%40mail.gmail.com >>>> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2BRAZ1%2Bu33NNK%2BgqNdijZs7a0V7YY4fasWCes2iGJ%2Bvg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "GWT Contributors" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com >>> . >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAM28XAsQGwM4MRA-aBxoze-1MQ_fzeCQp4Jxw1Hc2o0FiOtmHA%40mail.gmail.com >>> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAM28XAsQGwM4MRA-aBxoze-1MQ_fzeCQp4Jxw1Hc2o0FiOtmHA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2LYKb1U_1eTH0whd%3DUjXgaudG1NBqugy54eEq8Rw7eoA%40mail.gmail.com >> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2LYKb1U_1eTH0whd%3DUjXgaudG1NBqugy54eEq8Rw7eoA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAM28XAvkc6jJFK2-Kooc%3DvuNB_z0dyFE4u4qRsSVJZr1c2uSZw%40mail.gmail.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAM28XAvkc6jJFK2-Kooc%3DvuNB_z0dyFE4u4qRsSVJZr1c2uSZw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA3xcUbR-yRFDC9OwKZa6M%2B7O_qyVHAXbfBbCR5-rNbLeg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
